Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if make test modifies go mod files #205

Closed
wants to merge 1 commit into from
Closed

Check if make test modifies go mod files #205

wants to merge 1 commit into from

Commits on Nov 6, 2023

  1. Check if make test modifies go mod files 

    It's easy to accidentally leave out changes to go mod files (go.mod,
go.sum, go.work.sum) when preparing PRs, especially if you
rebase. Usually, any go operation would catch it, because the default
is `-mod readonly`; but, workspace files seem exempt from this, and
`go vet` doesn't appear to honour it either.

Therefore: add a backstop in the GitHub Actions workflow, to stop
incidental changes slipping through.

Signed-off-by: Michael Bridgen <[email protected]>
    @squaremo
    squaremo committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b652141 View commit details
    Browse the repository at this point in the history