Check if make test modifies go mod files
#205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to accidentally leave out changes to go mod files (go.mod, go.sum, go.work.sum) when preparing PRs, especially if you rebase. Usually, any go operation would catch it, because the default is `-mod readonly`; but, workspace files seem exempt from this, and `go vet` doesn't appear to honour it either. Therefore: add a backstop in the GitHub Actions workflow, to stop incidental changes slipping through. Signed-off-by: Michael Bridgen <[email protected]>
|
Closing in favour of just removing the workspace files (#206). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to accidentally leave out changes to go mod files (go.mod, go.sum, go.work.sum) when preparing PRs, especially if you rebase. Usually, any go operation would catch it, because the default is
-mod readonly; but, workspace files seem exempt from this, andgo vetdoesn't appear to honour it either.Therefore: add a backstop in the GitHub Actions workflow, to stop incidental changes slipping through.