Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When passed a DNS name, InitiateConnection only resolves one record; all records would be better #78

Open
nfirvine opened this issue Jul 26, 2017 · 1 comment
Open

When passed a DNS name, InitiateConnection only resolves one record; all records would be better #78

nfirvine opened this issue Jul 26, 2017 · 1 comment

Comments

@nfirvine
Copy link

https://github.com/weaveworks/mesh/blob/master/connection_maker.go#L96

If the host part of a peer is a DNS name, it'd be nice if that name were resolved and all resultant addresses were added to the list, instead of just one. This is a very common pattern in service discovery i.e. Consul.

(I'm not sure how this code would respond with a request to peer with oneself though?)
@nfirvine nfirvine mentioned this issue Jul 26, 2017
Closed
@pznamensky
Copy link

It would be useful in case of using dual stack (IPv4 and IPv6) too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfirvine @pznamensky