Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change concrete *log.Logger to mesh.Logger interface #37

Open
peterbourgon opened this issue Apr 4, 2016 · 2 comments
Open

Change concrete *log.Logger to mesh.Logger interface #37

peterbourgon opened this issue Apr 4, 2016 · 2 comments

Comments

@peterbourgon
Copy link
Contributor

Proposed interface

type Logger interface {
    Logf(format string, args ...interface{})
}
@bboreham
Copy link
Contributor

bboreham commented Apr 4, 2016

Compare https://github.com/Sirupsen/logrus/blob/master/logrus.go#L97

(not claiming I can see an easy middle ground)

See also weaveworks/weave@c38dcb1

@peterbourgon
Copy link
Contributor Author

Yeah, there's a lot to consider. I'm definitely against an interface with more than 1 method, see this presentation from a Go kit collaborator for a good recap of my journey with logging. And sorry to make you use that logLogger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants