New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport LocalConnection, favor an e.g. Overlayer interface #34

Open

peterbourgon opened this issue Mar 24, 2016 · 0 comments

Contributor

peterbourgon commented Mar 24, 2016

From #33,

It looks like LocalConnection would not need to exported either if it implemented an interface with an OverlayConn method, so the likes of https://github.com/weaveworks/weave/blob/master/router/network_router.go#L189 can use that instead of a cast to LocalConnection.

peterbourgon mentioned this issue

shrink Connection interface #33

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment