-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect container runtime to choose to start scope #243
Comments
I suggest some auto-detection along 3, that errors out if we cannot talk the docker/cri we have detected/guessed, with a clear message telling the user what went wrong and that they should specify the CRI socket path with the flag. |
3+4 sounds good to me too! |
What is happening with this? I thought we had some auto-detection in place already, do we not? |
Yes it was added in #252 But until I confirm it works, I do not want to close this. Ran into small issues like we need to change all our image names to prefix them with the |
ok. I would rather close this and have follow-up issues for breakages we find. That way it's easier to see what is left to do. |
Closed in #252 |
Reopening as we had to disable this for now until a new version of scope is released which includes the CRI and the flag. |
how is it going now? |
When the container runtime is not Docker, we need to pass the correct endpoint and flag to start scope with the correct CRI supported container runtime, for that we need to send the info to generate the correct manifest files and expose the socket in the volumes.
Right now finding out which container runtime the kubernetes cluster is using is not the easiest as that information is not exposed, but we can find out by:
I would suggest we try to guess on a best effort bases (trying with 3rd approach) and also add a flag (4th) to let the user override the runtime they use. At least as a temporary solution until this issue kubernetes/kubernetes#64460 exposes the container runtime information.
cc @leth @dlespiau What do you think?
The text was updated successfully, but these errors were encountered: