Using both the class dot notation and attribute map prevents evaluation of local variables #143

benzap · 2017-04-14T23:06:17Z

The code

(let [class-local-var "class-foo class-bar"]
  (hiccup.page/html5 
   [:body
    [:div.test {:class class-local-var}]]))

Expected output

<!DOCTYPE html>
<html><body><div class="test class-foo class-bar"></div></body></html>

Actual output

<!DOCTYPE html>
<html><body><div class="test class-local-var"></div></body></html>

Note that the symbol class-local-var was not evaluated into class-foo class-bar

Tested on Version 1.0.5

The text was updated successfully, but these errors were encountered:

benzap · 2017-04-14T23:08:26Z

This only appears to happen when you include a class with dot notation and through the map attributes :class keyword. The workaround currently would be to only use dot notation or only using map attributes until this is fixed.

…ributes Allow for the combination of classes in the tag keyword and non-literal class attributes by evaluating the latter at runtime.

Generate the correct class attribute of an element when the class names are both present as: - part of the element keyword (using the dot notation) - a non-literal value of the :class key in the attribute map (specifically when using a symbol as the value). Fixes issue weavejester#143

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using both the class dot notation and attribute map prevents evaluation of local variables #143

Using both the class dot notation and attribute map prevents evaluation of local variables #143

benzap commented Apr 14, 2017

benzap commented Apr 14, 2017

Using both the class dot notation and attribute map prevents evaluation of local variables #143

Using both the class dot notation and attribute map prevents evaluation of local variables #143

Comments

benzap commented Apr 14, 2017

The code

Expected output

Actual output

benzap commented Apr 14, 2017