Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple form-to with non GET or POST action leads to non unique IDs. #109

Open
mvitz opened this issue Dec 11, 2014 · 1 comment
Open

Comments

@mvitz
Copy link

mvitz commented Dec 11, 2014

We are currently using multiple forms with DELETE action on a single page. These forms are generated with: (form-to [:delete "/route"])

This generates a hidden field with id=_method for each form but HTML requires that any ID must be unique on the complete page.

Ring works even when the input field contains only a name=_method.

@mvitz
Copy link
Author

mvitz commented Jan 5, 2015

Any thoughts on this? If it is acceptable for you to not generate an ID for the hidden _method field I would create a PR.

mvitz added a commit to mvitz/statuses that referenced this issue Mar 13, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue Apr 3, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue Apr 8, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue Apr 22, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue May 1, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue Nov 23, 2015
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
mvitz added a commit to mvitz/statuses that referenced this issue Mar 10, 2016
By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant