Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #13

Open
iandunn opened this issue Jun 14, 2019 · 2 comments
Open

Memory leak #13

iandunn opened this issue Jun 14, 2019 · 2 comments

Comments

@iandunn
Copy link
Contributor

iandunn commented Jun 14, 2019

Continuing from #6

I got a spot script... warning from Firebox, and high CPU/memory usage again this morning. That's while running running master @ 4c8a092 (after #11 was merged) and hitting the local REST API every 3 seconds (instead of 60), but with service worker caching enabled, and after 10+ hours.

The browser still seems relatively responsive, though, except in the devtools Network tab, which users won't normally be accessing anyway. If anyone else is seeing problems and has time to test, that might be nice, but it might also be fine to go ahead and see what happens during WCEU. If there aren't any reports of problems, then it's probably not worth digging into further.

One thing worth noting, though, is that phones have significantly less CPU/memory than desktops, but will probably also cycle things out of memory more aggressively, especially when the display is off or the browser isn't the active app. Tablets may be the most vulnerable to this kind of thing, since users are more likely to keep them open throughout the day, but they're still relatively underpowered when compared to desktops.

@iandunn iandunn mentioned this issue Jun 14, 2019
@iandunn
Copy link
Contributor Author

iandunn commented Jun 21, 2019

Has anyone heard reports of this in the wild? If not, maybe the service worker caching and/or typical usage patterns makes it a non-issue.

Cutting down on the size of the API responses (#6) might also help.

If it's not causing tangible problems, then it's probably not worth spending any more time on, and can be closed. If there are reports of it, then we should move this issue to https://github.com/WordPress/wordcamp.org/

@avillegasn , @vdwijngaert , @vedanshujain, @westonruter, @iceablemedia , @nem-c , @tfrommen

@avillegasn
Copy link
Collaborator

I didn't heard any reports about memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants