Search mods by slug instead of generic search #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using only slug or name is too limited, maybe a fall back to slug when name yields no results? |
Really? It seems to me that the code limits the search to slugs only down here anyway: CurseForgeBadge-Unofficial/CFReader.py Lines 32 to 35 in e260631 There's no other conditional searches that follow or precede it. All it does is search and look for a slug with the name of the search filter in lowercase. I'll run the code and see if it works for each scenario, though now that I look at the code it seems I'll need to give get_downloads_author() some more attention. Simply searching for a slug might not work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #43. If a more generic search is necessary, some edits can be made.