Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedCM becomes mandatory #74

Open
agracia-foticos opened this issue Apr 29, 2024 · 26 comments
Open

FedCM becomes mandatory #74

agracia-foticos opened this issue Apr 29, 2024 · 26 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@agracia-foticos
Copy link

Describe the bug
GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

To Reproduce
Steps to reproduce the behaviour:

  1. Go to https://vue3-google-signin.wavezync.com/guide/one-tap-login.html
  2. Sign in with one tap
    image
  3. In console there is this error:
    [GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

Reproducible Example
If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@kasvith
Copy link
Collaborator

kasvith commented Apr 29, 2024

Hey thanks for bringing attention to this

@agracia-foticos
Copy link
Author

Hey thanks for bringing attention to this

Any idea of ​​the error? Can I bypass the error somehow?

@kasvith
Copy link
Collaborator

kasvith commented Apr 29, 2024

im checking the docs and trying to fix this in a new release

@kasvith
Copy link
Collaborator

kasvith commented Apr 29, 2024

it will be backward compatible for you

@agracia-foticos
Copy link
Author

im checking the docs and trying to fix this in a new release

THANKS A LOT!!!

@kasvith
Copy link
Collaborator

kasvith commented Apr 29, 2024

as i checked we arent even using there methods, but still gets the warning. i will dig into this

@kasvith kasvith added the bug Something isn't working label Apr 29, 2024
@kasvith kasvith self-assigned this Apr 29, 2024
@agracia-foticos
Copy link
Author

as i checked we arent even using there methods, but still gets the warning. i will dig into this

Do you know approximately what deadlines you have for uploading the new version with the patch applied?

@kasvith
Copy link
Collaborator

kasvith commented Apr 29, 2024

I cant provide a deadline sadly

@agracia-foticos
Copy link
Author

I cant provide a deadline sadly

We hope for news soon. If you need any other information, do not hesitate to ask.

@kasvith
Copy link
Collaborator

kasvith commented May 7, 2024

i still could not figure out this, we are not using any methods described by FedCM :(

@infinnie
Copy link

i still could not figure out this, we are not using any methods described by FedCM :(

Perhaps they enforce it automatically in supported browsers.

@jsony
Copy link

jsony commented Jun 25, 2024

Has it been fixed?

@kasvith
Copy link
Collaborator

kasvith commented Jun 25, 2024

Hi all, unfortunately the fix is unclear for me. this library does not use anything which is not working with FedCM as i looked into

@agracia-foticos
Copy link
Author

Any advance??

image

In your web also fails the login! :(

do you need another reproduction?

@kasvith
Copy link
Collaborator

kasvith commented Jul 10, 2024

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

@agracia-foticos
Copy link
Author

agracia-foticos commented Jul 10, 2024

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

image

versión of google chrome Versión 126.0.6478.126 (Build oficial) (64 bits)

image

@kasvith
Copy link
Collaborator

kasvith commented Jul 22, 2024

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

@agracia-foticos
Copy link
Author

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

Do you need anymore?

@kasvith
Copy link
Collaborator

kasvith commented Jul 22, 2024

Its bit confusing, if we at least use these deprecated methods its easier to remove them. but we dont use them at all. im not sure whether this is a false indicator

@JasonMSims
Copy link

@kasvith - these methods are defined in the PromptMomentNotification interface in interfaces/accounts.ts. According to the FedCM migration docs it looks like they should be removed altogether?

@kasvith
Copy link
Collaborator

kasvith commented Aug 19, 2024

@JasonMSims even they are defined they aren't being used anywhere

its mostly for the typescript stuff

i removed them locally and tried also, but same results

@agracia-foticos
Copy link
Author

Any advance???

@agracia-foticos
Copy link
Author

In https://vue3-google-signin.wavezync.com/guide/one-tap-login.html i try to login with one tap and this is the error

image

The fetch of the id assertion endpoint resulted in a network error: ERR_FAILED one-tap-login.html:1 The provider's token fetch resulted in an error response code. client:71 [GSI_LOGGER]: FedCM get() rejects with IdentityCredentialError: Error retrieving a token.

@kasvith
Copy link
Collaborator

kasvith commented Oct 30, 2024

hi, im planning to do a major upgrade with new vite and add FedCM support to project

@kasvith kasvith added this to the v3.0.0 milestone Nov 21, 2024
@kasvith
Copy link
Collaborator

kasvith commented Nov 21, 2024

added this to v3 milestone

@mrniamster
Copy link

have bee waiting for this since april, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants