-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FedCM becomes mandatory #74
Comments
Hey thanks for bringing attention to this |
Any idea of the error? Can I bypass the error somehow? |
im checking the docs and trying to fix this in a new release |
it will be backward compatible for you |
THANKS A LOT!!! |
as i checked we arent even using there methods, but still gets the warning. i will dig into this |
Do you know approximately what deadlines you have for uploading the new version with the patch applied? |
I cant provide a deadline sadly |
We hope for news soon. If you need any other information, do not hesitate to ask. |
i still could not figure out this, we are not using any methods described by FedCM :( |
Perhaps they enforce it automatically in supported browsers. |
Has it been fixed? |
Hi all, unfortunately the fix is unclear for me. this library does not use anything which is not working with FedCM as i looked into |
hi i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard |
Do you need anymore? |
Its bit confusing, if we at least use these deprecated methods its easier to remove them. but we dont use them at all. im not sure whether this is a false indicator |
@kasvith - these methods are defined in the PromptMomentNotification interface in interfaces/accounts.ts. According to the FedCM migration docs it looks like they should be removed altogether? |
@JasonMSims even they are defined they aren't being used anywhere its mostly for the typescript stuff i removed them locally and tried also, but same results |
Any advance??? |
In https://vue3-google-signin.wavezync.com/guide/one-tap-login.html i try to login with one tap and this is the error
|
hi, im planning to do a major upgrade with new vite and add FedCM support to project |
added this to v3 milestone |
have bee waiting for this since april, any updates? |
Describe the bug
GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment
To Reproduce
Steps to reproduce the behaviour:
[GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment
Reproducible Example
If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service
Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: