New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not handle children that are numbers #31
Comments
Ouch, that's indeed a tricky one. I will try to find a good solution for this, but right now it's not easy, since I am relying on string's properties to identify it. |
Imo that's not a big limitation. I think it's fair to assume that numbers need to be casted to strings by components. The same problem also exists for |
For the record, we're talking about these lines here, right? I'm wondering, can we simply reverse the test and the condition? So instead of This should match anything that's not a vnode object, including strings, numbers and booleans, right? (if that works, also maybe swap the terminals of the ternary expression and save one of the |
I think we can close this? |
...although it's still on a devel branch that might should be merged back to master? |
Does not nicely handle vnode instances which are numbers, only strings. Maybe if type number => render to string.
The text was updated successfully, but these errors were encountered: