Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Astro and Starlight versions #111

Closed
infomiho opened this issue Apr 28, 2024 · 3 comments
Closed

Upgrade Astro and Starlight versions #111

infomiho opened this issue Apr 28, 2024 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@infomiho
Copy link
Collaborator

Reported by user:

Starlight's sidebar doesn't include a trailing slash ("/") at the end of the URL, leading to a 301 redirect to the page. It is a minor thing, but SEO-wise it is not great. I tried to look it up online but couldn't find any solution 😦

Astro team response:

You are on an older version
Quite an old version of the 3 libraries
starlight-blog fixed the trailing slash on 0.6.0, but your project is on 0.4.0
It requires Astro 4 and Starlight 0.19 since 0.5.0, but your project is using Astro 3 and Starlight 0.13
You might want to upgrade them

Thread: https://ptb.discord.com/channels/686873244791210014/1232786035230904341/1232786035230904341

We should upgrade our Astro version and Starlight version to get the benefits of latest fixes.

@infomiho infomiho added the help wanted Extra attention is needed label Apr 28, 2024
@infomiho infomiho changed the title Upgrade Astro and Starlight version Upgrade Astro and Starlight versions Apr 28, 2024
@lakshaygoyal01
Copy link

Hi @infomiho, I want to work on this issue. Can you please assign this to me?

@rbatista191
Copy link

As discussed in Discord, here is my first try at it:

Ricardos-MacBook-Pro:aiblogarticles1 rbatista19$ cd blog
Ricardos-MacBook-Pro:blog rbatista19$ npx @astrojs/upgrade

 astro   Integration upgrade in progress.

      ◼  @astrojs/tailwind is up to date on v5.1.0
      ●  @astrojs/check will be updated to v0.5.10
      ●  @astrojs/starlight will be updated to v0.21.5
      ●  @astrojs/starlight-tailwind will be updated to v2.0.2
      ▲  astro will be updated to  v4.7.0 

  wait   One package has breaking changes. Continue?
         Yes

 check   Be sure to follow the CHANGELOG.
         astro Upgrade to Astro v4

 ██████  Installing dependencies with npm...

      ▲  error Dependencies failed to install, please run the following command manually:
npm install @astrojs/[email protected] @astrojs/[email protected] @astrojs/[email protected] [email protected]
Ricardos-MacBook-Pro:blog rbatista19$ npm install @astrojs/[email protected] @astrojs/[email protected] @astrojs/[email protected] [email protected]
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @astrojs/[email protected]
npm ERR! node_modules/@astrojs/starlight
npm ERR!   peer @astrojs/starlight@">=0.9.0" from @astrojs/[email protected]
npm ERR!   node_modules/@astrojs/starlight-tailwind
npm ERR!     @astrojs/starlight-tailwind@"2.0.2" from the root project
npm ERR!   peer @astrojs/starlight@">=0.11.0" from [email protected]
npm ERR!   node_modules/starlight-blog
npm ERR!     starlight-blog@"^0.4.0" from the root project
npm ERR!   1 more (the root project)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! @astrojs/starlight@"0.21.5" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/astro
npm ERR!   peer astro@"^4.2.7" from @astrojs/[email protected]
npm ERR!   node_modules/@astrojs/starlight
npm ERR!     @astrojs/starlight@"0.21.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/rbatista19/.npm/_logs/2024-04-29T16_28_36_980Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/rbatista19/.npm/_logs/2024-04-29T16_28_36_980Z-debug-0.log

@infomiho infomiho self-assigned this May 6, 2024
@vincanger
Copy link
Collaborator

resolved in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants