Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tags for released versions #13

Open
gonzalolarralde opened this issue Aug 11, 2023 · 2 comments
Open

Get tags for released versions #13

gonzalolarralde opened this issue Aug 11, 2023 · 2 comments

Comments

@gonzalolarralde
Copy link

Hi!

I'm not sure if the information is entirely recoverable but is there a chance to get tags to match the released versions? (or at least 0.1.0). While trying to workaround for some seemingly missing concepts (specifically Promises and Protection) I see there's a commit dated on Apr 25th that includes some of these developments but these are not on 0.1.0 even tho it's dated Apr 27th.

So if there's a way to get that it'd be terrific. Also to know if there are plans on releasing the latest work.

Thanks for the hard work! I'm still in my very early stages with rust but I'm enjoying working with this wrapper.

@syrusakbary
Copy link
Member

Yeah, sure. We'll create a tag for 0.1.0.

While trying to workaround for some seemingly missing concepts (specifically Promises and Protection) I see there's a commit dated on Apr 25th that includes some of these developments

I completely missed this, if you want to open a PR with the additions that would be great!

@gonzalolarralde
Copy link
Author

Awesome thanks!
So when I was working on that noticed that some code was there, but now re-reading the repository history seems like when #8 was merged all that got in, and I was just confused by the dates of the original commits. So sorry for the fuzz.
Handling of promises natively created and JSValueProtect was what I was looking for. I might wait until those changes land to a released version.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants