Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a public docker image for bashful #59

Open
wagoodman opened this issue Sep 13, 2018 · 4 comments
Open

Create a public docker image for bashful #59

wagoodman opened this issue Sep 13, 2018 · 4 comments

Comments

@wagoodman
Copy link
Owner

No description provided.

@karuppiah7890
Copy link

How does this look to you ? 😄 https://github.com/karuppiah7890/bashful-docker/blob/master/Dockerfile

@karuppiah7890
Copy link

It's a very simple docker image. Some improvements that could be done :

  1. Install an exact version in the docker image. Currently installing using go get leads to showing no version, commit, build time in the bashful command run, which is bad as it will lead to bad debugging when an issue is reported by a developer

  2. Based on 1, we can tag the docker image with versions

  3. Work on making the image smaller. I can try to do this. Since bashful is a golang app, I will see how I can get the static binary into an image as small as possible. Something like busybox or alpine 😄 and we can tag it accordingly. If you are planning to have other images with different base images, we could do that too, like Ubuntu, Debian and others. I can may be help with that too. I still have to learn some things, like what people usually do and how people consume when they want to compose the app into another docker image, like someone may want to install bashful inside their already existing image and there may be other use cases. May be we could consider them too

Does it make sense ? What do you think ? And What are your thoughts on creating a Docker Image for bashful ?

And also, these are just ideas out of the top of my head. We can just work on one thing at a time and iteratively get this done.

@wagoodman
Copy link
Owner Author

@karuppiah7890 it's a good start. I think I would probably make it even slimmer by not even using go get to grab/compile it. Instead a plain wget https://github.com/wagoodman/bashful/releases/download/v0.1.1/bashful_0.1.1_linux and throwing that into the bin directory would be simpler. We'd need to adjust go-releaser to have a plain linux binary available for download to do this. This would make it easier to control which version is built (and tagged accordingly).

I think it would make a lot of sense to provide an installer script via https://github.com/goreleaser/godownloader to allow anyone to pull this into their own image. In that way instead of providing several flavors (ubuntu, debian, centos, etc...) this would allow anyone to pull this tool into their base image with one command.

@karuppiah7890
Copy link

karuppiah7890 commented Sep 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Kanban Board
  
Backlog
Development

No branches or pull requests

2 participants