-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for guild roles #26
Comments
@Netherwhal Thank you for the feature request. To call this API, we would first call https://discord.com/api/users/@me/guilds to get all the guild IDs that the logged-in user has joined, while also calling this API for each. In other words, the more guilds a user is a member of, the more APIs will be executed. The big problem is that this API has a very low Rate Limit. I actually called the API and found that it can only be called 5 times in 5 minutes (probably per logged in user).
Therefore, if we implement this API, it is likely to fall into the Rate Limit soon unless we perform some filtering such as limiting it to specific guild IDs (1 to 5). |
By limiting it to one specific guild this will become an awesome feature imo. |
Btw, the rate limit is based on the token of the user, so if 100 people is trying to authenficate, they have rate limit for each user and not one for all application. So this is possible and simple to implement ! |
There is a fork that's doing this work but for groups instead, https://github.com/pjeanjean/keycloak-discord |
@wadahiro Could you consider creating a PR if you consider your dev operational? |
For those of y'all who want to get this working right this moment, I've forked the previous repo, updated it to v22, added documentation on role syncing & merged #34 into it. https://github.com/NotActuallyTerry/keycloak-discord You can grab a pre-built jar via the Releases @wadahiro @pjeanjean @rpeper I can open a PR to merge these changes into the repo if you're happy w the changes |
Hey, I don't mind at all if you reuse what I did on my fork and make it into a PR.
|
Grafana does this nicely with
would allow us to map roles from discord with roles in keycloak?
The text was updated successfully, but these errors were encountered: