Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible escaping / quoting issue in entrypoint.sh #169

Open
ostollmann opened this issue Dec 15, 2022 · 1 comment
Open

Possible escaping / quoting issue in entrypoint.sh #169

ostollmann opened this issue Dec 15, 2022 · 1 comment

Comments

@ostollmann
Copy link

The following fails silently:

~/Repos/mwl2/ dev* > docker run --workdir /home --rm -v `pwd`:"/home" -it -e FIREBASE_TOKEN -e DEBUG=1 w9jds/firebase-action:v11.16.0 appdistribution:distribute --app ***** --release-notes "Features and/or bug fixes" --groups "actyx" --debug app-release-unsigned.apk
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

The following works:

~/Repos/mwl2/ dev* > docker run --workdir /home --rm -v `pwd`:"/home" -it -e FIREBASE_TOKEN -e DEBUG=1 w9jds/firebase-action:v11.16.0 'appdistribution:distribute --app ***** --release-notes "Features and/or bug fixes" --groups "actyx" --debug app-release-unsigned.apk'

In the second call I wrap all my arguments in single quotes.

Could this be a problem with sh -c "firebase $*" from /entrypoint.sh?

Note: I am running the docker image myself for debugging purposes. The same problem happens when running on Github.

@w9jds
Copy link
Owner

w9jds commented Dec 18, 2022

No this is mostly likely just how GitHub handles passing information into their action infrastructure. These containers can be run locally, but my guess is that it's not standard as it supports both docker and JS/TS actions. I would recommend looking at how it runs when GitHub runs it in their system to get a good idea on how to replicate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants