Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEEFY spec #682

Merged
merged 39 commits into from
Nov 2, 2023
Merged

BEEFY spec #682

merged 39 commits into from
Nov 2, 2023

Conversation

bhargavbh
Copy link
Contributor

@bhargavbh bhargavbh commented Jul 27, 2023 •
edited
Loading

First draft of the BEEFY spec.
TODOs:

  • describe voting and round selection in more depth
  • overall polishing
  • Subsampling based light client protocol cna be moved to the Implementer's Guide section as its not part of the core polkadot protocol.

bhargavbh and others added 22 commits July 12, 2023 11:48
@bhargavbh
rebased to main, added sections on beefy, and file on beefy analysis
f3266ef
@bhargavbh
added new row for BEEFY keys
124c8e0
@bhargavbh
MMR spec and interface contributed by Heverson
f2f194d
@heversonbr
added mmr root merging direction to mmr definition
30cbe68
@heversonbr
updated mmr description
152d022
@bhargavbh
changes to mmr tree reverted.round selection added
da9b0b2
@Noc2 @bhargavbh
Update chap-host-api.md
d6cc7d7 
Initial spelling fixes
@Noc2 @bhargavbh
Update chap-overview.md
9126dfb 
Fix speling
@Noc2 @bhargavbh
Update chap-runtime-api.md
c935ae1 
fix some spelling issues
@Noc2 @bhargavbh
Update chap-state.md
8fe7c91 
small fixes
@Noc2 @bhargavbh
Update id-consensus.md
92794c9 
Spelling fixes
@Noc2 @bhargavbh
Update sect-block-production.md
b086bd6 
Quick spelling fixes
@Noc2 @bhargavbh
Update id-extrinsics.md
e573c7d 
fix spelling errors
@Noc2 @bhargavbh
Update part-polkadot-host.md
97664c4 
fix spelling errors
@Noc2 @bhargavbh
Update id-glossary.md
770c1d7 
fix spelling errors
@Noc2 @bhargavbh
Update id-cryptography-encoding.md
17a25b8 
Some quick spelling fixes
@Noc2 @bhargavbh
Update id-weights.md
59537bb 
Quick spelling fixes
@Noc2 @bhargavbh
Update sect-lightclient.md
ff5560c 
Quick spelling fixes
@Noc2 @bhargavbh
Update chapter-anv.md
c19efc3 
Quick spelling fixes
@Noc2 @bhargavbh
Update sect-metadata.md
cdb284c 
Quick spelling fixes
@Noc2 @bhargavbh
Update sect-lightclient.md
27009bf 
Quick spelling fixes
@Noc2 @bhargavbh
Update chapter-anv.md
0e3b0e8 
Quick spelling fixes
@bhargavbh bhargavbh requested a review from drskalman July 27, 2023 19:18
@Noc2 Noc2 self-requested a review July 31, 2023 08:01
@bhargavbh bhargavbh mentioned this pull request Sep 7, 2023
Closed
@heversonbr heversonbr mentioned this pull request Sep 13, 2023
Closed
drskalman
drskalman requested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@drskalman drskalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of "Bridge design (BEEFY)" section.

docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
@bhargavbh bhargavbh mentioned this pull request Oct 2, 2023
Closed
@bhargavbh bhargavbh self-assigned this Oct 9, 2023
@bhargavbh
Copy link
Contributor Author

@Noc2 Can you please take a look. After your review, can merge this for now. Potentially, the random Subsampling protocol can be added to the implementer's guide in a different PR.

@bhargavbh bhargavbh requested a review from heversonbr October 9, 2023 15:42
@bhargavbh bhargavbh marked this pull request as ready for review October 10, 2023 07:46
Noc2
Noc2 requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the Motivation section, or should this be part of the implementer guide?

docs/sect-finality.md Outdated Show resolved Hide resolved
heversonbr
heversonbr suggested changes Oct 10, 2023
View reviewed changes
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Outdated Show resolved Hide resolved
docs/sect-finality.md Show resolved Hide resolved
@bhargavbh
Copy link
Contributor Author

I suggest merging this PR for now. How the light client verifies (via interactive Random Subsampling of signatures) BEEFY payload can be part of the implementers guide in a separate PR.

@acatangiu acatangiu mentioned this pull request Oct 18, 2023
Merged
@bhargavbh bhargavbh mentioned this pull request Oct 30, 2023
Open
@Noc2 Noc2 merged commit 49017da into main Nov 2, 2023
3 checks passed
@Noc2 Noc2 deleted the bnb/beefy-spec branch November 2, 2023 07:50
@bhargavbh bhargavbh mentioned this pull request Nov 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drskalman drskalman drskalman requested changes

@Noc2 Noc2 Noc2 approved these changes

@heversonbr heversonbr heversonbr approved these changes

Assignees

@bhargavbh bhargavbh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhargavbh @heversonbr @Noc2 @drskalman