Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test approach for resource integrity #35

Open
mprorock opened this issue Jun 13, 2023 · 4 comments
Open

test approach for resource integrity #35

mprorock opened this issue Jun 13, 2023 · 4 comments
Assignees

Comments

@mprorock
Copy link

per pr w3c/vc-data-model#1140 need descriptions of test approach and possible other considerations regarding type and related for followon PRs

@OR13 for more color commentary if needed

@iherman
Copy link
Member

iherman commented Jul 6, 2023

The issue was discussed in a meeting on 2023-07-05

  • no resolutions were taken
View the transcript

2.2. test approach for resource integrity (issue vc-data-model#1153)

See github issue vc-data-model#1153.

Manu Sporny: This is definitely pre-CR.
… It's about knowing how the group will test the feature.
… We need thoughts from Mike P. on how to test the feature. Then we can close the issue.

Michael Prorock: +1 manu.

Manu Sporny: It need to be there until there's an agreed upon plan.

Michael Prorock: Assign me the issue.

@OR13
Copy link

OR13 commented Aug 2, 2023

We should cross reference from the test suite repos... when we have them.

@iherman
Copy link
Member

iherman commented Aug 3, 2023

The issue was discussed in a meeting on 2023-08-02

  • no resolutions were taken
View the transcript

2.4. test approach for resource integrity (issue vc-data-model#1153)

See github issue vc-data-model#1153.

Michael Prorock: How do we test this? We could check if hash matches, build into VCDM tests -- fairly straight forward.

Kristina Yasuda: Are you volunteering to do the PR?

Michael Prorock: I can provide sample code for this, could go into PR, or whatever.

Michael Prorock: we did.

Orie Steele: I might be misremembering, thought we added property for protecting context integrity, if securing specification wanted to demonstrate conformance, it would have to write tests around it.
… Manu sent email about data integrity suites -- would expect to see some test case there for this, would also expect to see stuff for VC-COSE-JOSE test suite and would love to see that adopted.

Michael Prorock: +1 orie - and I am happy to add to vc-jose tests.

Orie Steele: We dont' have adopted work items for test suites in group.

Kristina Yasuda: Moving issue to VC-JOSE-COSE repo?

Orie Steele: This particular core data model issue is fine to stay on core data model -- it will need to be tested concretely in test suites for securing core data model, those tests suites will use different approaches, I'd leave it where it is.
… I'd file issues in test suites repos, if we had those.

@brentzundel brentzundel transferred this issue from w3c/vc-data-model Aug 30, 2023
@OR13
Copy link

OR13 commented Sep 1, 2023

@mprorock how do we want to address this in spec.yaml?

We could bundle all contexts (url, content and hash) in each spec.yaml... that seems wasteful.

We could create a new kind of spec.yaml that can be referenced by the existing ones, so that the validation section, can "pass / succeed" by comparison to a "reference" as opposed to by comparison to a "value".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants