Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor request handling #7

Open
5 tasks
vweevers opened this issue Feb 5, 2018 · 0 comments
Open
5 tasks

Refactor request handling #7

vweevers opened this issue Feb 5, 2018 · 0 comments

Comments

@vweevers
Copy link
Owner

vweevers commented Feb 5, 2018

  • Make #request internal
  • Pass headers to query callback
  • Then handle session responses in set and reset
  • Catalog, schema, timezone and session headers only need to be set on initial statement request
  • Do not reuse opts and headers objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers