Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: crop video #56

Open
mauron85 opened this issue Jul 7, 2016 · 6 comments
Open

Suggestion: crop video #56

mauron85 opened this issue Jul 7, 2016 · 6 comments

Comments

@mauron85
Copy link

mauron85 commented Jul 7, 2016

Hi, outstanding work. Is it possible to add video cropping?

@vvo
Copy link
Owner

vvo commented Jul 7, 2016

Yes, taking a PR to do so, if ffmpeg has it then we can do it.

@mauron85
Copy link
Author

mauron85 commented Jul 7, 2016

yeah. ffmpeg does have it https://ffmpeg.org/ffmpeg-filters.html#crop so should be possible

@vvo
Copy link
Owner

vvo commented Jul 8, 2016

Ok, have a look at the code, you might be surprised how easy it can be to add

@mauron85
Copy link
Author

mauron85 commented Jul 8, 2016

Definitely. :-) So is it now so, that you will implement it?

@vvo
Copy link
Owner

vvo commented Jul 8, 2016

Sorry no I will not implement it, but I am really interested in it and I invite you to submit a pull request or having a try at it.

Clone the repo, type npm link in it (it will make gifify available globally), hack the code, try some videos, push a pull request!

@mauron85
Copy link
Author

mauron85 commented Jul 8, 2016

I feel with you. From my own experience, I know how hard (impossible) is to convince people to do PR. I'll probably take look on it, when I find spare time between my biz and another open source project I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants