Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nativescript-vue and nativescript-vue-template-compiler versions is not compatible each other #13

Open
osmanertem opened this issue Sep 3, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@osmanertem
Copy link

nativescript-vue and nativescript-vue-template-compiler versions must be compatible with each other.

Currently;
nativescript-vue (v2.4.0), nativescript-vue-template-compiler (v2.2.2)
The plugin throws an exception(tag of undefined) while rendering the template in the following line;
https://github.com/nativescript-vue/nativescript-vue/blob/master/platform/nativescript/compiler/modules/router.js#L6

In our current implementation, router-view does not have a parent. But nativescript-vue-template-compiler expects router-view to have a parent after v2.2.2.

Suggestions to fix the issue

  1. Change router-view implementation to have a parent in App.vue or main.native.js
  2. Create an issue to change the implementation that requires a parent for router-view. In our opinion, it may not be necessary to check if the router-view element has a parent.
@osmanertem osmanertem added the bug Something isn't working label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants