Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useFileDialog): add a parameter reset #3059

Merged
merged 2 commits into from May 12, 2023
Merged

Conversation

zaqvil
Copy link
Contributor

@zaqvil zaqvil commented May 4, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

solved #3045.

Additional context


🤖 Generated by Copilot at de2ad5c

Add openToClear option to useFileDialog to clear file input value. Update file input state logic to handle the new option.

🤖 Generated by Copilot at de2ad5c

  • Add openToClear option to useFileDialog hook to allow clearing the file input value when opening the file dialog (link, link, link, link)
  • Define reset function to set files to null and clear input value if input element exists (link)
  • Call reset function before clicking input element in open function if openToClear is true (link)
  • Set default value of openToClear to false in DEFAULT_OPTIONS object (link)
  • Add openToClear property to UseFileDialogOptions interface (link)

* Clear value when open file dialog.
* @default false
*/
openToClear?: Boolean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openToClear?: Boolean
reset?: boolean

@sxzz sxzz changed the title feat(useFileDialog):Add a parameter openToClear feat(useFileDialog):Add a parameter reset May 12, 2023
@sxzz sxzz changed the title feat(useFileDialog):Add a parameter reset feat(useFileDialog):Add a parameter reset May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants