Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vuex with the latest version of vue has a broken hot reload test #2241

Open
3 tasks done
alecgibson opened this issue Jan 18, 2024 · 1 comment
Open
3 tasks done

Comments

@alecgibson
Copy link

Version

4.1.0

Describe the bug

When developing with a fork of vuex, I noticed that vuex tests break when bumping vue to the latest version:

 FAIL  test/unit/hot-reload.spec.js
  ● Hot Reload › getters

    expect(received).toBe(expected) // Object.is equality

    Expected: 10
    Received: 1

      279 |     })
      280 |
    > 281 |     expect(vm.a).toBe(10)
          |                  ^
      282 |     store.dispatch('check', 10)
      283 |
      284 |     if (isSSR) {

      at Object.toBe (test/unit/hot-reload.spec.js:281:18)

Reproduction

  1. Check out vuejs/vuex main branch
  2. Run yarn test
  3. Tests pass
  4. Update vue: yarn add --dev vue@latest
  5. Run yarn test again
  6. Tests fail

Expected behavior

Tests pass on latest version of vue — presumably this means there's broken behaviour when using vuex with the latest version of vue?

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@alecgibson
Copy link
Author

alecgibson commented Jan 18, 2024

Did a bit of investigating on version numbers at least, and it looks like this broke in [email protected]. Tests pass fine in [email protected], but fail in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant