-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some lifecycle hooks apis #216
Comments
This issue looks like it's related to PR #123 ? I've created new |
If an update to a value is passed layer by layer from outside to inside, it will eventually only trigger the update hook of the component that actually uses the value. Such a design is obviously more efficient. packages/runtime-vapor/tests/apiLifecycle.spec.ts | +319 to +327 // FIXME: not called
expect(calls).toEqual([
// 'root beforeUpdate',
// 'mid beforeUpdate',
'child beforeUpdate',
'child updated',
// 'mid updated',
// 'root updated',
]) But this design differs from core. How should we balance between the two? |
relates #215
There seem to be some points where the behavior differs from the original.
I added FIXME comments in packages/runtime-vapor/tests/apiLifecycle.spec.ts.
The text was updated successfully, but these errors were encountered: