Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue next - Support for shadowMode #1842

Open
tcnijmeijer opened this issue Jun 17, 2021 · 3 comments
Open

Vue next - Support for shadowMode #1842

tcnijmeijer opened this issue Jun 17, 2021 · 3 comments

Comments

@tcnijmeijer
Copy link

What problem does this feature solve?

Currently the next branch does not yet support the shadowMode option which is necessary to make proper use of the vue-web-component-wrapper possible. When will support for this option be added to the Vue3 compatible next branch?

Without this option it wouldn't make much sense to try and use the web-component-wrapper as the styles of the components wouldn't be injected in the shadowRoot of the web-component made.

What does the proposed API look like?

It would basically work the same as the Vue2 compatible vue-loader.

I wouldn't mind contributing to the solution here, but I'm not sure what the intended way of going about solving this issue is. Is it the intention to re-use the vue-style-loader, or is there another approach you guys have in mind? I was thinking perhaps the CSS-injection could be integrated into vue-loader in all cases instead of letting style-loader handle this in some cases but not in other cases.

@tcnijmeijer
Copy link
Author

I gave adding the suggested support a shot myself. See: #1850

@sherlock1982
Copy link

sherlock1982 commented Aug 12, 2021

Without this option I can't say it really supports Web Components.
There's no point to inject styles for child components in a head tag :-)
Also would be nice to have <style module> support back.
Otherwise web components will be too much affected by global styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants