Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import docsearch css only when provider is algolia #2423

Closed
wants to merge 1 commit into from
Closed

fix: import docsearch css only when provider is algolia #2423

wants to merge 1 commit into from

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented May 26, 2023

No description provided.

@brc-dd
Copy link
Member

brc-dd commented May 27, 2023

Nah, we need that CSS to be present. That VPAlgoliaSearchBox.vue is dynamically imported. Open the deploy preview, it is showing this:

image

@sxzz sxzz marked this pull request as draft May 27, 2023 08:03
@brc-dd
Copy link
Member

brc-dd commented May 27, 2023

PS: the local search provider mode also uses docsearch styles for the search button

@sxzz sxzz closed this Jun 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sxzz @brc-dd