Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outline nav does not has duplicative assistive tech-exclusive text [#3800] #3803

Merged
merged 1 commit into from Apr 26, 2024

Conversation

olets
Copy link
Contributor

@olets olets commented Apr 18, 2024

Fixes #3800

Before

  • The outline had two navigation elements, one labelled but one not
  • The labelled navigation's label was exclusive to assistive tech. It was at best duplicative of and at worst in conflict with the configurable heading displayed visually, which is also available to assistive tech.

After

The outline has one navigation element. Its label is the configurable heading displayed visually.

Testing

  1. On a Vitepress site using the released version, on any page with an outline, use a screen reader or other assistive tech to read the outline. Confirm that the nested navigation adds no value, that the labelled nav's label is distinct from what is displayed visually, and that the divergent assistive tech experience adds no value.

On this branch,

  1. Run axe DevTools on a page with an outline. Confirm that there is no regression error in the outline
  2. Use a screen reader or other assistive tech to read the outline. Confirm that the single nav is labelled by the visually displayed heading, and that the assistive tech experience of the outline is closer to the visual experience than it was.

olets added a commit to olets/vitepress that referenced this pull request Apr 18, 2024
outline nav does not has duplicative assistive tech-exclusive text [upstream vuejs#3803]
@brc-dd brc-dd merged commit 733d986 into vuejs:main Apr 26, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accessibility: outline nav has duplicative assistive tech text not displayed visually
2 participants