Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History back issue while using iOS Safari #3658

Closed
4 tasks done
isishome opened this issue Mar 15, 2024 · 3 comments · Fixed by #3671
Closed
4 tasks done

History back issue while using iOS Safari #3658

isishome opened this issue Mar 15, 2024 · 3 comments · Fixed by #3671
Labels
bug Something isn't working

Comments

@isishome
Copy link

isishome commented Mar 15, 2024 •
edited

Describe the bug

When using iOS Safari, if you move to the actions link on the home page and then swipe history back, clicking on the elements on the home page is interrupted once.
Works fine from the second touch.

Reproduction

home > click action button > swipe history back > click action button

Expected behavior

No response to action button on home page after history back.

System Info

iPhone SE2 (2020)
iOS 17.4
safari

Additional context

No response

Validations
@isishome isishome added the bug: pending triage Maybe a bug, waiting for confirmation label Mar 15, 2024
@brc-dd brc-dd added bug Something isn't working and removed bug: pending triage Maybe a bug, waiting for confirmation labels Mar 15, 2024
@gwansikk
Copy link
Contributor

I delved into this bug out of curiosity.

  • The swipe-back feature works fine on macOS Safari.
  • However, the issue arises on iOS and iPadOS Safari.
  • I observed that the swipe-back behaves differently on iOS and iPadOS.

In essence, the swipe-back on mobile devices uniquely engages the back-forward cache*, leading to a situation where the cache is retrieved and rendered, but JavaScript does not execute.

I have found a solution to this issue but am researching for a potentially better approach.

Additionally, I plan to investigate and address the following

  • Whether this bug is replicated in other versions of Safari
  • Consulting Apple's developer documentation for a superior solution
  • Understanding why this issue is exclusive to mobile Safari

Would it be okay to submit a PR once all these points are thoroughly examined?

Thanks!

*It's noted that this cache differs from the standard caching as it only caches the HTML code.

@brc-dd
Copy link
Member

brc-dd commented Mar 21, 2024 •
edited

Yeah PRs are welcome. But I'm not seeing this issue with https://vuejs.org/, what are we doing different here (other than theme) 👀

0xlau added a commit to 0xlau/vitepress that referenced this issue Mar 21, 2024
@0xlau
fix(theme): fixed history back issue while using iOS Safari (vuejs#3658)
25a0df1
@0xlau 0xlau mentioned this issue Mar 21, 2024
Merged
@0xlau
Copy link
Contributor

0xlau commented Mar 21, 2024

Yeah PRs are welcome. But I'm not seeing this issue with https://vuejs.org/, what are we doing different here (other than theme) 👀

This information is crucial. 😄

I checked the docs repository on the official website of Vuejs.org and found that they are using version rc.33, which is a breakthrough point for this issue.

I tried to fix it and submit a PR #3671 .

brc-dd added a commit that referenced this issue Apr 26, 2024
@0xlau @brc-dd
fix(theme): leaking event listener when going back/forward on Safari …
1a72181 
…on iOS (#3658) (#3671)

Co-authored-by: Divyansh Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): fixed history back issue while using iOS Safari (#3658) 0xlau/vitepress
4 participants
@isishome @gwansikk @brc-dd @0xlau