Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation when initializing VitePress configuration #3641

Open
4 tasks done
0xlau opened this issue Mar 7, 2024 · 2 comments · May be fixed by #3640
Open
4 tasks done

feat: add validation when initializing VitePress configuration #3641

0xlau opened this issue Mar 7, 2024 · 2 comments · May be fixed by #3640
Labels
enhancement New feature or request stale

Comments

@0xlau
Copy link
Contributor

0xlau commented Mar 7, 2024

Is your feature request related to a problem? Please describe.

If the configuration directory of VitePress is outside the project root directory, the project will not run correctly, so add this validation logic to ensure that the path entered by the user is within the root directory.

Describe the solution you'd like

I'd like to complete @yyx990803 remaining TODO code and achieve the purpose of prompting users to "Make sure directory is inside.".

p1

And the pull request (#3640) is the solution for this issue.

Describe alternatives you've considered

No response

Additional context

No response

Validations

@0xlau
Copy link
Contributor Author

0xlau commented Mar 15, 2024

@brc-dd Should I change this issue from feature label to bug label?

@brc-dd brc-dd added the enhancement New feature or request label Mar 15, 2024
@brc-dd
Copy link
Member

brc-dd commented Mar 15, 2024

Not a bug technically, just an additional validation. I'll review your PR when I get some time.

@github-actions github-actions bot added the stale label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants