Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation (Render Function section) #44

Merged
merged 1 commit into from Mar 27, 2023

Conversation

jay-es
Copy link
Contributor

@jay-es jay-es commented Mar 27, 2023

Translated the "Render Function" & "Custom Elements" section into Japanese.

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for eager-kowalevski-41f498 ready!

Name Link
🔨 Latest commit ce91745
🔍 Latest deploy log https://app.netlify.com/sites/eager-kowalevski-41f498/deploys/6421767e27839100075d0e28
😎 Deploy Preview https://deploy-preview-44--eager-kowalevski-41f498.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

link: '/ja/breaking-changes/listeners-removed'
},
{
text: '$attrs includes class & style',
text: '$attrs class style を包含',
Copy link
Contributor Author

@jay-es jay-es Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Written in Japanese for better explanation.)

なるべく原文に近い感じを残しつつ、(他の見出しと合わせるために)体言止めのタイトルを考えた結果こうなりました。

主語を入れ替えて、「class と style は $attr に統合」などにすると自然になりそうな気はしています(ニュアンスは変わってしまうので悩ましいところですが)

@jay-es
Copy link
Contributor Author

jay-es commented Mar 27, 2023

@kazupon Please review this PR:pray:

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazupon kazupon merged commit 7d1a9cb into vuejs:main Mar 27, 2023
5 checks passed
@jay-es jay-es deleted the ja5-render branch March 28, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants