Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-core): type support for useAttrs and $attrs #5011

Merged
merged 4 commits into from
Dec 15, 2024
Merged

feat(language-core): type support for useAttrs and $attrs #5011

merged 4 commits into from
Dec 15, 2024

Conversation

KazariEX
Copy link
Collaborator

resolve #5008

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 17, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5011

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5011

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5011

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5011

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5011

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5011

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5011

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5011

commit: 48b29e5

@KazariEX KazariEX changed the title feat(language-core): type support for useAttrs feat(language-core): type support for useAttrs and $attrs Nov 19, 2024
zhiyuanzmj
zhiyuanzmj previously approved these changes Nov 19, 2024
View reviewed changes
@KazariEX KazariEX dismissed stale reviews from davidmatter and zhiyuanzmj via 48b29e5 December 15, 2024 10:06
@KazariEX KazariEX merged commit b3b088b into vuejs:master Dec 15, 2024
5 checks passed
@KazariEX KazariEX deleted the feat/useAttrs branch December 15, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiyuanzmj zhiyuanzmj zhiyuanzmj left review comments

@davidmatter davidmatter davidmatter left review comments

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk

@so1ve so1ve Awaiting requested review from so1ve

@KermanX KermanX Awaiting requested review from KermanX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$attrs or ReturnType<typeof useAttrs()> is always Datawhen fallthroughAttributes: true
3 participants
@KazariEX @davidmatter @zhiyuanzmj