Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LAUNCH_EDITOR env support #369

Closed
webfansplz opened this issue May 8, 2024 · 2 comments · Fixed by #373
Closed

feat: LAUNCH_EDITOR env support #369

webfansplz opened this issue May 8, 2024 · 2 comments · Fixed by #373
Assignees
@webfansplz
Labels
documentation Improvements or additions to documentation enhancement New feature or request upstream Related to an upstream issue vite scope: vite plugin

Comments

@webfansplz
Copy link
Member

webfansplz commented May 8, 2024 •
edited

Add an option to configure the open-in-editor target IDE (maybe named launchEditor), make the feature easier to use and configure.

Be related to:

#125 #185 #341 #366 #367

Refer to:

https://github1s.com/yyx990803/launch-editor/blob/master/packages/launch-editor/guess.js#L17-L18
@webfansplz webfansplz added enhancement New feature or request pr welcome vite scope: vite plugin upstream Related to an upstream issue documentation Improvements or additions to documentation and removed pr welcome labels May 8, 2024
@webfansplz webfansplz self-assigned this May 8, 2024
@webfansplz webfansplz mentioned this issue May 8, 2024
Merged
@Smef
Copy link
Contributor

Smef commented May 21, 2024

To add some context to this, the LAUNCH_EDITOR env is being overwritten upstream in vite-plugin-vue-inspector. The launchEditor option being added here helps work around this, but the change to allow the env to be respected needs to happen in the other package. PR here. This is affecting Nuxt Devtools as well.

@Smef
Copy link
Contributor

Smef commented May 23, 2024 •
edited

It looks like devtools-next is also setting this and overwriting the env, so it was being forced to "code" in both packages. I'm submitting a PR for this one as well.

PR Submitted here: #401

@Smef Smef mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webfansplz webfansplz

Labels
documentation Improvements or additions to documentation enhancement New feature or request upstream Related to an upstream issue vite scope: vite plugin
Projects
None yet
Milestone
No milestone
2 participants
@Smef @webfansplz