feat(types/jsx): support jsxImportSource, avoid global JSX conflict #7958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No longer implicitly register global JSX types by default
- This avoid conflict when using Vue in the same project with React
- Global registration must now be done by explicitly importing /
referencing `vue/jsx`, or listing it in `compilerOptions.types`.
- Add `vue/jsx-runtime` to support `jsxImportSource` usage
- Can enable globally by setting `compilerOptions.jsxImportSource` to `'vue'`
- Can also opt-in per-file with `/** @jsxImportSource vue */`
5 tasks
yyx990803
added
the
|
It’s awesome to see Vue adding support for the JSX automatic runtime! I spotted some bugs though. #7959 explains and resolves them. |
Glad to see this! Trying to work with Vue 2.7 (templates only; no JSX/TSX) and React in the same project and dealing with conflicting types when using vue-tsc/Volar. Would it be possible to backport this to 2.7? If not feasible, is there a workaround to have full TS support for both? |
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
…uejs#7958) - No longer implicitly register global JSX types by default - This avoid conflict when using Vue in the same project with React - Global registration must now be done by explicitly importing / referencing `vue/jsx`, or listing it in `compilerOptions.types`. - Add `vue/jsx-runtime` to support `jsxImportSource` usage - Can enable globally by setting `compilerOptions.jsxImportSource` to `'vue'` - Can also opt-in per-file with `/** @jsxImportSource vue */`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Based on and supersedes #7083
Closes #1033
Closes #1034
vue/jsx, or listing it incompilerOptions.types.vue/jsx-runtimeto supportjsxImportSourceusagecompilerOptions.jsxImportSourceto'vue'/** @jsxImportSource vue */Note that global JSX types requires explicit opt-in, which is technically a breaking change, but this is a type-only change and the update path is trivial, so it aligns with the release policy if we release this in a minor.
Update: In 3.3, the JSX types will still be registered globally by default. We plan to remove the global registration in 3.4 while we get IDE support aligned during the 3.3 lifecycle.
This is also needed to land zero-config SFC Generics support in Volar vuejs/language-tools#2546