Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transition is breaking/flickering when enter is canceled (fix #2482, #10677) #10688

Merged
merged 1 commit into from Apr 22, 2024
Merged

transition is breaking/flickering when enter is canceled (fix #2482, #10677) #10688

merged 1 commit into from Apr 22, 2024

Conversation

quiteeasy
Copy link
Contributor

@quiteeasy quiteeasy commented Apr 12, 2024 •
edited by yyx990803

When the transition's enter event is canceled final CSS styles are applied and all transition's *-active styles are removed for a short period so the element is flickering, getting its final state(no transition classes applied)

Screen.Recording.2024-04-12.at.6.37.17.PM.mov

fix #2482
fix #10677

@quiteeasy quiteeasy mentioned this pull request Apr 12, 2024
Closed
@quiteeasy
Copy link
Contributor Author

quiteeasy commented Apr 12, 2024 •
edited

fix #10677 #2482

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB 34.4 kB (-1 B) 31 kB (+11 B)
vue.global.prod.js 148 kB 53.7 kB (-2 B) 48 kB (+121 B)

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54 kB 21.2 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.8 kB
overall 64.4 kB 24.9 kB (-1 B) 22.5 kB (-38 B)

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Apr 18, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ❌ failure ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ❌ failure ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ✅ success ✅ success
vuetify ✅ success ❌ failure
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@quiteeasy
Copy link
Contributor Author

The /ecosystem-ci run failure doesn't seem to be related to the changes in the PR

@yyx990803 yyx990803 merged commit 65109a7 into vuejs:main Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@quiteeasy @edison1105 @vue-bot @yyx990803