Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix app.provide type checking #10603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(types): fix app.provide type checking #10603

wants to merge 3 commits into from

Conversation

makedopamine
Copy link

fix #10602

@pikax
Copy link
Member

pikax commented Apr 3, 2024

@makedopamine are you able to add a few typescripts tests for this? Just to make sure is working and does not regress

@makedopamine
Copy link
Author

@makedopamine are you able to add a few typescripts tests for this? Just to make sure is working and does not regress

I've updated the code. Please take a look.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.6 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.8 kB
overall 64.4 kB 24.9 kB 22.5 kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app.provide is not type safe
3 participants
@makedopamine @pikax @sodatea