Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more maintainers #3080

Open
visnaut opened this issue Nov 23, 2019 · 32 comments
Open

Add more maintainers #3080

visnaut opened this issue Nov 23, 2019 · 32 comments

Comments

@visnaut
Copy link
Contributor

visnaut commented Nov 23, 2019

It's evident by the many PRs that there's great enthusiasm in adding to this list. The current maintainers have done a great job, as this list has been a great resource that myself and many others turn to, again and again.

However, the long backlog, and lack of merges (only 1 in the past month) is also a sign that the current maintainers need a hand, and as such, I'd like to propose that more be added to spread the workload.

I recently attended VueConf Toronto, and the core team that was present really encouraged the community to contribute and participate. In the spirit of doing so, I'd like to volunteer to be a maintainer here, as have others. I would happily lend a few hours a week to assisting this project.

Please let us know how the community can help @kazupon @LinusBorg.

@ajtruex
Copy link
Contributor

ajtruex commented Jan 5, 2020

I'd also like to volunteer to help maintain this repo as @visnaut already suggested.

Let me know if there is anything I can do to help @LinusBorg @kazupon.

@Akryum
Copy link
Member

Akryum commented Jan 6, 2020

Hi! You can also help with either adding packages to https://awesomejs.dev/ or contributing to https://github.com/Akryum/awesomejs.dev (which replaces vue-curated).

@DannyFeliz
Copy link
Contributor

I would like to help with the maintenance of this project.

@Scrum
Copy link
Collaborator

Scrum commented Feb 10, 2020

@Akryum Hi, I would like to help

@heygambo
Copy link
Contributor

I can make some time to go over PRs as well

@Jogai
Copy link
Collaborator

Jogai commented Mar 6, 2020

Average time to resolve an issue

Percentage of issues still open

Who are the maintainers? It looks like no pr's are merged anymore, and I think some are closed by contributors due to lack of response , example: #3123

@Scrum
Copy link
Collaborator

Scrum commented Mar 6, 2020

@LinusBorg @kazupon @Akryum ping ping ping

@LinusBorg
Copy link
Member

LinusBorg commented Mar 7, 2020

Okay, so here's the deal:

  • We don't really have the capacity to track this repo reliably anymore - obviously.
  • We realize we need some suport from y'all to make this go forward.
  • At the same time we are not comfortable giving merge privileges to people who we don't know well enough, yet.

So here's what we propose:

  • Those wanting to help moderate this, please speak up here again.
  • Start reviewing PRs, check wether they fulfill the criteria for being on the list (laid on here).
  • Kindly ask contributors whose PRs don't match those criteria to update them accordingly.
  • Approve PRs that do match the criteria
  • Ping us in said PRs and we will merge them.

Once you have shown yourself to be a nicer and reliable person we will give you merge permission so you can continue to do this work on your own.


At the same time we want to make something clear: We think the usefulness of this form of "awesome-list" declines after a certain scale of the ecosystem has been reached, and we think we are there already, pretty much.

So we think that in the future, such a list might be better handled on e.g. https://awesomejs.dev - we could put you there as moderators checking contributions as well.

But we aren't sure when and how we should deprecate this list right here in favour of said other tool, so options are welcome.

@LinusBorg LinusBorg pinned this issue Mar 7, 2020
@Scrum
Copy link
Collaborator

Scrum commented Mar 7, 2020

Those wanting to help moderate this, please speak up here again.

I am ready to help.

@Jogai
Copy link
Collaborator

Jogai commented Mar 9, 2020

I strongly disagree with some of your statements.

We think the usefulness of this form of "awesome-list" declines after a certain scale of the ecosystem has been reached, and we think we are there already, pretty much.

As the ecosystem grows its more important to have an awesome list to be able to quickly get an overview of real good content in the community

So we think that in the future, such a list might be better handled on e.g. https://www.awesomejs.dev - we could put you there as moderators checking contributions as well.

I think the audience is mostly the open source community and developers in general. Those are familiar with github and the https://github.com/sindresorhus/awesome list. I think its important to keep it this way (for reasons discussed enough in the awesome repo) and not make it external. (point in case, the external link gives a 404 right now).

edit: external services exist that use aweseme lists as a base dataset, see https://github.com/sindresorhus/awesome#related

@visnaut
Copy link
Contributor Author

visnaut commented Mar 10, 2020

Thank you for the thoughtful response, @LinusBorg

At the same time we want to make something clear: We think the usefulness of this form of "awesome-list" declines after a certain scale of the ecosystem has been reached, and we think we are there already, pretty much.

So we think that in the future, such a list might be better handled on e.g. https://www.awesomejs.dev - we could put you there as moderators checking contributions as well.

But we aren't sure when and how we should deprecate this list right here in favour of said other tool, so options are welcome.

If this is how the maintainers feel, I'd be more in favour of just ripping off the band-aid, placing a deprecation notice on this repo, and moving all efforts to AwesomeJS.

However, I'd like to point out that of the three main categories in this list, Resources, Projects Using Vue.js, and Components & Libraries, AwesomeJS only covers the latter. And in that, it excels.

But I would argue that this list is very important for gauging the overall health of the ecosystem; not just the availability of packages, but for the training available, and for name-checking other successful uses of Vue in the real world; information that is hard to come by otherwise.

With that in mind, perhaps we can consider deprecating the Components & Libraries list, point people to AwesomeJS instead, and focus on the other sections of this list. I think that would provide a good balance of pointing people to the best resources available, and not duplicating maintainers' efforts.

Those wanting to help moderate this, please speak up here again.

Yes, I'm in 🙋🏻‍♂️

@visnaut
Copy link
Contributor Author

visnaut commented Mar 10, 2020

(point in case, the external link gives a 404 right now).

@Jogai Try https://awesomejs.dev without the www.. Though I would agree that it should just work or redirect regardless.

@Scrum
Copy link
Collaborator

Scrum commented Mar 10, 2020

@LinusBorg sketched a sample checklist of criteria by which PR can be closed.

Checklist

  • git: pull request template structure not broken
  • git: empty commit
  • git: link not to repository
  • git: broken PR
  • git: no conflicts resolved
  • git: doublicate
  • time: not updated for more than 6 months
  • category: not in its category
  • lists: not the last on the list
  • docs: no documentation
  • docs: non-english documentation
  • project: commercial product
  • project: dead project
  • project: does not accept donat
  • site: no link to the site
  • site: site with errors
  • site: not actively using vuejs
  • site: not original

Follow the rules CONTRIBUTING

It seems to me that you can give a chance for old PR sizes of 1 week, after which you can close the task if there is no movement on it.

It would be great to be able to put labels in order to mark already viewed or pending PR decisions.

@Scrum
Copy link
Collaborator

Scrum commented Mar 10, 2020

@LinusBorg In relation to PR, we can use templates with checklist as I have done in the project https://github.com/post/post-static/blob/master/.github/pull_request_template.md

Regarding issue you can make blanks as in https://github.com/Scrum/slims/issues/new/choose

@Scrum
Copy link
Collaborator

Scrum commented Mar 11, 2020

@LinusBorg @Akryum

So we think that in the future, such a list might be better handled on e.g. https://www.awesomejs.dev - we could put you there as moderators checking contributions as well.

I am ready to assist in the development of this project, naturally only after that I will do all the work on the current project.

Presumably I will create a structured date file with a list from the current project that can be used in https://www.awesomejs.dev

ps if I fit your criteria)

@Akryum
Copy link
Member

Akryum commented Mar 11, 2020

However, I'd like to point out that of the three main categories in this list, Resources, Projects Using Vue.js, and Components & Libraries, AwesomeJS only covers the latter. And in that, it excels.

We discussed redirecting effort to https://github.com/dobromir-hristov/vuecommunity about the sections other than Components & Libraries.

@Jogai Try https://awesomejs.dev without the www.. Though I would agree that it should just work or redirect regardless.

This is fixed! 🔧

I am ready to assist in the development of this project, naturally only after that I will do all the work on the current project.

Awesome! I don't have contributing documentation available yet though.

Presumably I will create a structured date file with a list from the current project that can be used in https://www.awesomejs.dev

This could help migrating data to AwesomeJS

@ajtruex
Copy link
Contributor

ajtruex commented Mar 23, 2020

Those wanting to help moderate this, please speak up here again.

I'd still like to help maintain this repo as already suggested @Akryum @LinusBorg.

@Scrum
Copy link
Collaborator

Scrum commented Mar 23, 2020

@Akryum What do you think about this data format?

[
  {
    name: 'Level 1',
    children: [{
      name: 'Level 1.1',
      children: [{
        name: 'text link 1',
        path: 'https://url-link-1',
        description: 'A description link 1'
      },{
        name: 'text link 2',
        path: 'https://url-link-2',
        description: 'A description link 2'
      }]
    },{
      name: 'Level 1.2',
      description: '*Description leve 1.2*',
      children: [{
        name: 'text link 1',
        path: 'https://url-link-1'
      },{
        name: 'text link 2',
        path: 'https://url-link-2'
      }]
    }]
  }
]

@LinusBorg
Copy link
Member

@ajtruex As explained, start reviewing PRs and work with @Scrum to get them merged.

@Scrum you can ping me when you think I can add him so you have a backup / collaborator to share workload with.

@Scrum
Copy link
Collaborator

Scrum commented Mar 23, 2020

@LinusBorg Accepted

@Scrum
Copy link
Collaborator

Scrum commented Mar 26, 2020

@LinusBorg @Akryum Hi, I created an example of how to automatically generate data and readme in the format described above

let me know what you think about it

P.S. I'm going to test a little more in my repository and then transfer to the main repository awesome-vue

@ghost
Copy link

ghost commented Mar 26, 2020

I'd also like to help @LinusBorg
I am constantly exploring the Vue.js ecosystem and constantly finding new things.
I would really like to add them to here & help much more people.
Thanks!

@Scrum
Copy link
Collaborator

Scrum commented Apr 1, 2020

So we think that in the future, such a list might be better handled on e.g. https://awesomejs.dev - we could put you there as moderators checking contributions as well.

@LinusBorg @Akryum Hi, can I be added to the moderators for checking contributions?

Awesome! I don't have contributing documentation available yet though.

At the expense of the criteria, you can stick to the current list from CONTRIBUTING

This could help migrating data to AwesomeJS

In relation to this, I realized that it is necessary to develop api for the possibility of adding contributions.

I could make adding contributions directly from PR

@Scrum
Copy link
Collaborator

Scrum commented Apr 6, 2020

@Scrum
Copy link
Collaborator

Scrum commented Apr 10, 2020

@LinusBorg ping

@richardeschloss
Copy link

richardeschloss commented May 1, 2020

I was going to suggest either JSONify'ing the markdown, or MD'ing the JSON of awesome projects. Could that make this far easier to maintain? To have the data, as it comes in populate the markdown. Criteria for auto-population could include a variety of metrics, such as Github star count, download count, awesomejs.dev bookmark count. Plus, for a project I have, I would find it useful if I could tap into awesomedev's API so I can [more] easily plug in existing components (the search on the UI is pretty awesome!)

I think the truth is, the Vue community will just keep on expanding and one can expect the list of awesome projects/components/libraries to grow at a pace that's faster than what a single human can keep up with manually. Suppose we encounter a "good problem": 1 billion more people want to use Vue tomorrow...pat on the back but...1% want to add awesome libraries...so a maintainer would manually fill out 1% of 1 billion items.

@Jogai
Copy link
Collaborator

Jogai commented May 2, 2020

The bigger awesome lists do have some stuff in place to keep it manageable. Maybe thats needed, but the format of the list isnt an issue for other lists.

@Scrum
Copy link
Collaborator

Scrum commented May 2, 2020

@richardeschloss Hi

if I could tap into awesomedev's API

https://awesomejs.dev/api/playground

@richardeschloss
Copy link

@Scrum Yes! Thanks!

@Jogai
Copy link
Collaborator

Jogai commented Jan 13, 2023

@LinusBorg Did I prove myself yet to be nice and reliable? Because I would like to get added as contributor in that case...

@Scrum
Copy link
Collaborator

Scrum commented Jan 16, 2023

@LinusBorg Did I prove myself yet to be nice and reliable? Because I would like to get added as contributor in that case...

@LinusBorg I support this candidate, very useful and reliable.

@LinusBorg
Copy link
Member

Then welcome, and thanks for your work 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants