Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to support rspack? #653

Open
3 tasks done
leewhite97 opened this issue Mar 27, 2024 · 10 comments
Open
3 tasks done

Are there any plans to support rspack? #653

leewhite97 opened this issue Mar 27, 2024 · 10 comments
Labels
enhancement New feature or request upstream

Comments

@leewhite97
Copy link

Clear and concise description of the problem

unplugin has started supporting rspack, are there plans for the same for vue-macros

Suggested solution

powered by unplugin rspack support

Alternative

No response

Additional context

No response

Validations

@leewhite97 leewhite97 added the enhancement New feature or request label Mar 27, 2024
@sxzz
Copy link
Member

sxzz commented Mar 27, 2024

Most of the features of Vue Macros should now be supported by Rspack, although they haven't been introduced in the public documentation yet. You can go ahead and use it to see if there are any issues.

import VueMacros from 'unplugin-vue-macros'

VueMacros.rspack()

@leewhite97
Copy link
Author

Most of the features of Vue Macros should now be supported by Rspack, although they haven't been introduced in the public documentation yet. You can go ahead and use it to see if there are any issues.

import VueMacros from 'unplugin-vue-macros'

VueMacros.rspack()

This doesn't work, it seems because unplugin-combine doesn't support rspack

@sxzz
Copy link
Member

sxzz commented Mar 28, 2024

Or just try webpack version, and see what's going on

sxzz added a commit that referenced this issue Mar 28, 2024
upgrade unplugin-combine
relate #653
sxzz added a commit that referenced this issue Mar 28, 2024
upgrade unplugin-combine
relate #653
@sxzz
Copy link
Member

sxzz commented Mar 28, 2024

Try [email protected]

@leewhite97
Copy link
Author

Thank you so much!!

But I encountered some difficulties in getting started:
There will be a reference error such as defineOptions is not defined.
My running environment is vue2 + rspack.

I'm not sure if I'm missing any configuration.
here is minimal demo: https://github.com/leewhite97/vue-macros-vue2-rspack

@sxzz sxzz added the bug Something isn't working label Mar 29, 2024
@sxzz
Copy link
Member

sxzz commented Mar 29, 2024

Most of issues are resolved by Vue Macros, but there's stil a issue about enforce caused by Rspack itself.

@sxzz sxzz added upstream and removed bug Something isn't working labels Mar 29, 2024
@sxzz
Copy link
Member

sxzz commented Mar 29, 2024

I raised an issue web-infra-dev/rspack#6068 to Rspack. Let's wait until the bug is fixed by Rspack team.

@sxzz
Copy link
Member

sxzz commented Apr 11, 2024

It should fixed in Rspack v0.6. Try template https://github.com/vue-macros/vue2-rspack

However, some features still cannot work as expected, like defineModels. See unplugin docs and issue web-infra-dev/rspack#3408

@leewhite97
Copy link
Author

it works, awesome!!!

@sxzz
Copy link
Member

sxzz commented Apr 24, 2024

I think it's good to keep it open until the upstream issues are resolved.

@sxzz sxzz reopened this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream
Projects
None yet
Development

No branches or pull requests

2 participants