Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vScope #357

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

AliceLanniste
Copy link
Contributor

@AliceLanniste AliceLanniste commented May 4, 2023

Description

I have now implemented the v-scope directive, which supports nested directives and single directive.I will refactor later.I have no idea about if and for condition. If you get an idea,we can discusss.

Linked Issues

closes #146

Additional context

@stackblitz
Copy link

stackblitz bot commented May 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: e194d62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@vue-macros/v-scope Minor
unplugin-vue-macros Patch
@vue-macros/astro Patch
@vue-macros/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 4, 2023 12:19 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 4, 2023 12:19 Inactive
@sxzz sxzz changed the title Feat v scope feat: add vScope May 5, 2023
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 18:14 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 18:33 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 18:33 Inactive
@sxzz
Copy link
Member

sxzz commented May 5, 2023

@AliceLanniste I just simplified the code a lot and pushed it (force). Don't forget to reset to the latest commit.

@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 18:40 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 5, 2023 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 5, 2023 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros May 9, 2023 03:27 Inactive
@vercel vercel bot temporarily deployed to Preview – unplugin-vue-macros-coverage May 9, 2023 03:27 Inactive
@sxzz sxzz enabled auto-merge (squash) August 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable Definition in Template
2 participants