Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify python path independently from ms-python extension #258

Open
ytimenkov opened this issue Dec 16, 2020 · 5 comments
Open
Labels
up for grab Pull requests are welcome.

Comments

@ytimenkov
Copy link

First thank you for awesome extension!

The problem: when working on python projects I use virtualenv with project's dependencies (as the most recommended and natural way).

However this means interference with extension's language server / linter even for simple README.rst files (which in most cases are rendered by Git browser). This is extremely inconvenient when there is a large number of small components because I have to install needed packages all the time (especially if those virtual envs are recreated) or sometimes just impossible (when testing legacy python2).

So it would be nice to have an option to always use specific python version for documentation rendering independent from ms- python extension which can be set globally.

@lextm lextm added the up for grab Pull requests are welcome. label Dec 16, 2020
@lextm
Copy link
Member

lextm commented Dec 16, 2020

I don't have time to improve virtual env support until next week. So leave this one open for a while.

@ytimenkov
Copy link
Author

It's fine, I realized that I can hack js directly in the extension folder. Problem solved until the next update 😂

Just to make sure: it's not about using venv, is on contrary about no using it: global interpreter + pip3 install --user is what I'd like to have (as for other python tools).

@lextm
Copy link
Member

lextm commented Mar 10, 2022

Similar to what I explained in #344,

  • switching to esbonio lowers the bar to Python >=3.6
  • Older Python versions are now end of life.

So no plan to address such issues that won't help general Python developers.

@lextm lextm closed this as completed Mar 10, 2022
@ytimenkov
Copy link
Author

ytimenkov commented Mar 10, 2022

This is not the same. It's not about python version, it's about the extension using python environment which is set up for different purposes.
I have multiple venvs in multiple projects, like dozens of them.

Every time I open any project, or do checkout, the extension asks me to install something which messes up venv. I don't have language server nor sphinx in my venv and I don't want to, when I develop python code (documentation is usually generated in a separate CI job and sphinx is installed on condition).

What is the problem to allow specify sphinx and LS commands directly? I would rather install them using pipx and share globally for all projects. The current behavior is easy to keep.

I also disagree with your comment about Python developers. reST and your extension is pretty much usable outside Python world. Very helpful tool.

@ytimenkov
Copy link
Author

A first link in Google for pipx actually give a very good case: https://pycon.switowski.com/02-packages/pipx/

@lextm lextm reopened this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grab Pull requests are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants