Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Implement cmdline in statusbar #1977

Closed
2 tasks done
xiyaowong opened this issue May 18, 2024 · 6 comments
Closed
2 tasks done

feature: Implement cmdline in statusbar #1977

xiyaowong opened this issue May 18, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@xiyaowong
Copy link
Collaborator

xiyaowong commented May 18, 2024

Did you check the docs?

  • I have read all the vscode-neovim docs
  • I understand the fundamental limitations of the plugin and believe this request to be reasonable

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

  1. Implement it.
  2. Provide option for users to choose between quickpick or statusbar

Describe alternatives you've considered

Additional context

Previous request: #288 (comment)

This is very easy to achieve with vscode-neovim. Compared with quickpick, it is difficult to implement the wildmenu. Everything else is an advantage

@xiyaowong xiyaowong added the enhancement New feature or request label May 18, 2024
@xiyaowong xiyaowong changed the title feature: Implement cmdline in statusbar [RFC]feature: Implement cmdline in statusbar May 18, 2024
@ollien
Copy link
Collaborator

ollien commented May 18, 2024

Personally, I really don't like having the commandline in the status bar. Too many extensions already take up that space, and it can be frustrating to try and read longer text. That said, I do recognize it has some advantages, so I understand the preference. I would hope there would be an option to keep the quickpick.

@xiyaowong
Copy link
Collaborator Author

xiyaowong commented May 19, 2024

Personally, I really don't like having the commandline in the status bar. Too many extensions already take up that space, and it can be frustrating to try and read longer text.

Me too, but cmdline isn't used often and isn't long either. :)

I would hope there would be an option to keep the quickpick.

Of course we should keep quickpick

@theol0403
Copy link
Member

VSCodeVim uses the status bar. It has some advantages, but there are no completions which is a major issue. With more bindings now supported in the quickpick menu, I think we should just try to improve the ergonomics.

@xiyaowong
Copy link
Collaborator Author

Cmdline is very good at present.

@xiyaowong xiyaowong reopened this Jun 10, 2024
@xiyaowong xiyaowong changed the title [RFC]feature: Implement cmdline in statusbar feature: Implement cmdline in statusbar Jun 10, 2024
@theol0403
Copy link
Member

Why reopen? Edge-case bugs in quickpick can and will be fixed.

@xiyaowong
Copy link
Collaborator Author

Anyway, this is a feature worth considering. Edge cases always exist. If the implementation isn't straightforward, I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants