-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Tracker: Sync viewport scroll #1261
Comments
We already set the selection based on the neovim cursor from the external buffer, but we should also scroll so that it's visible. This might be better fixed with proper syncing like vscode-neovim#1261 but for now it makes :help work a lot nicer.
We already set the selection based on the neovim cursor from the external buffer, but we should also scroll so that it's visible. This might be better fixed with proper syncing like vscode-neovim#1261 but for now it makes :help work a lot nicer.
We already set the selection based on the neovim cursor from the external buffer, but we should also scroll so that it's visible. This might be better fixed with proper syncing like vscode-neovim#1261 but for now it makes :help work a lot nicer.
* feat(buffer): add external buffer doc provider This opens a document with a proper buffer name and matches it to the appropriate neovim external buffer. The document is "readonly" as far as VSCode is concerned, but it can still be edited by setting `modifiable`, so we still need to sync buffer changes whenever it updates. This can break highlighting, however. * fix(buffer): scroll to selection on buffer open We already set the selection based on the neovim cursor from the external buffer, but we should also scroll so that it's visible. This might be better fixed with proper syncing like #1261 but for now it makes :help work a lot nicer. * refactor(buffer): improve logs, change URI scheme * fix(buffer): escape external buffer name on Windows Building a vscode.Uri throws an exception if the `path` component doesn't match a certain expected format, which Windows file paths do not. Uri.file() properly escapes/converts file paths as needed. * fix(test): end nvim client connection gracefully Instead of forcefully destroying the client connection, it's nicer to let it end with FIN first, allowing the server to gracefully close. This prevents a lot of noisy errors that make it hard to read test output. * fix(buffer): notify doc change after buffer event Ensure we notify for document change after other buffer event processing. Enforcing order like this seems to help with asynchronous ordering / timing issues on Windows. * fix(buffer): catch error on external buffer open
Anything new here? This is driving me crazy as I use |
@mikkelsvartveit C-d doesn't work? |
@xiyaowong It works, but it does not behave in the same way as (neo)vim. What happens in real Vim is that the cursor moves down, but the window also scrolls accordingly, resulting in the cursor staying in the same position on the screen. In vscode-neovim, it just moves the cursor down half a page but doesn't scroll the viewport. |
#983 has workarounds for viewpoint scroll |
This topic tracks fixing scrolling synchronisation.
Issues:
/
incorrectly matches for long line #161workbench.action.compareEditor.nextChange
andworkbench.action.compareEditor.previousChange
#1027The text was updated successfully, but these errors were encountered: