Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable support for mutli-mount entry. #124

Open
elqr opened this issue May 1, 2018 · 5 comments
Open

enable support for mutli-mount entry. #124

elqr opened this issue May 1, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@elqr
Copy link

elqr commented May 1, 2018

$key in autofs/manifests/mapping.pp and autofs/types/fs_mapping.pp should allow a space character.
Current pattern Pattern[/\A\S+\z/] does not allow offeset directories or directories with a space in the name. Proposed new pattern: Pattern[/\A\S+.*\z/]

From autofs docs:
centos autofs docs

mount-point options location
where:
mount-point is the autofs mount point. This can be a single directory name for an indirect mount or the full path of the mount point for direct mounts. Each direct and indirect map entry key (mount-point above) may be followed by a space separated list of offset directories (sub directory names each beginning with a "/") making them what is known as a mutli-mount entry.

Sample code:

autofs::mapfile {
    '/mnt/example':
        path     => '/etc/auto.example',
        mappings => [
            { 'key' => "example /Company\\ Home", 'options' => 'rw,soft,intr', 'fs' => 'server.example.com:/shares' }
        ]
}
@juniorsysadmin juniorsysadmin added the bug Something isn't working label May 1, 2018
@dhollinger dhollinger changed the title enable support for white space in mount point enable support for mutli-mount entry. Jun 15, 2018
@dhollinger
Copy link
Member

Updated description to better reflect the goal of this issue.

Will take a look as soon as I can, though we will accept PRs.

@dhollinger dhollinger added enhancement New feature or request and removed bug Something isn't working labels Jun 15, 2018
@dhollinger
Copy link
Member

While this issue is unexpected behavior from @elqr's perspective, this is functionally a feature request rather than a bug report as this is currently functioning as intended.

@knightcraw
Copy link

knightcraw commented Oct 26, 2018

Is this planned also for multi support in auto.master as well?
I also get the syntax error when use multi map in auto.master

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Autofs::Mount[mount]: parameter 'mapfile' expects a match for Variant[Stdlib::Windowspath = Pattern[/^(([a-zA-Z]:[\/])|([\/][\/][^\\\/]+[\/][^\\\/]+)|([\/][\/]?[\/][^\\\/]+))/], Stdlib::Unixpath = Pattern[/^/([^\/\0]+/)$/], Autofs::Mapentry = Pattern[/\A([a-z]+(,[a-z]+)?:\S+|-hosts)\z/]], got 'multi ldap:ou=auto.mount,ou=site1,dc=example,dc=com -- ldap:ou=auto.mount,ou=all,ou=views,dc=example,dc=com'

@dhollinger
Copy link
Member

When I can get around to it, yes. However, it will be some time before I will make it back around to this codebase. We will accept PRs or I can ping someone in the community to see if they have time to try and tackle this

@lschweiss-wustl
Copy link

FYI, I just submitted a PR ( #164 ) that adds multi-mount support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants