Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Maximum depth exceeded (Minified react issue #185) #4831

Open
1 of 3 tasks
Youyoun opened this issue Sep 23, 2024 · 0 comments
Open
1 of 3 tasks

[BUG] Maximum depth exceeded (Minified react issue #185) #4831

Youyoun opened this issue Sep 23, 2024 · 0 comments
Labels
bug Bug fixes

Comments

@Youyoun
Copy link

Youyoun commented Sep 23, 2024

Describe the problem

Hello, thanks for this awesome project !

I've been using fiftyone for a moment, and I have an issue that happens on all of my datasets. Note that all datasets are created with multiple DynamicEmbeddedDocuments, which contain a lot of information.

When I click on an image to open the detailed view, I get an error of Maximum update depth exceeded.

Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.

Most of my datasets are created the same way, so the issue is probably in link with what information is embedded inside the documents. The amount of samples affects whether this error happens or not, and I can fix this issue by filtering most of the fields, and keeping only those that interest me in the detailed view (when it happens). This hints me towards two possible reasons:

  • One of the fields is erroneous ?
  • Having a lot of fields causes this issue.

I tried to check for the first case if that works, by doing some kind of dichotomous search. I could not find a specific culprit, only that removing some fields with multiple elements fixed the issue. I'm leaning towards the second case, and would be glad to get your input if any. Note that removing most fields and keeping only 5 or so documents fixes the issue 100% of the time.

Code to reproduce issue

I do not have a minimal code to reproduce the error, but if necessary I could try to mime the effect of having a lot of fields, and see if it breaks. Any idea into what might be causing the issue ?

System information

  • OS Platform and Distribution : Ubuntu 22.04
  • Python version (python --version): 3.11.8
  • FiftyOne version (fiftyone --version): 0.23.5
  • FiftyOne installed from (pip or source): pip

Other info/logs

I don't know where to get any logs, would be happy to share them if I can.

Willingness to contribute

The FiftyOne Community encourages bug fix contributions. Would you or another
member of your organization be willing to contribute a fix for this bug to the
FiftyOne codebase?

  • Yes. I can contribute a fix for this bug independently
  • Yes. I would be willing to contribute a fix for this bug with guidance
    from the FiftyOne community
  • No. I cannot contribute a bug fix at this time
@Youyoun Youyoun added the bug Bug fixes label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant