Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.1? #87

Open
Habbie opened this issue May 17, 2024 · 11 comments
Open

release v0.1? #87

Habbie opened this issue May 17, 2024 · 11 comments
Milestone

Comments

@Habbie
Copy link
Member

Habbie commented May 17, 2024

Nice/needed (please add):

  • I think I'd like to support a few more plain sensor types (things that just show a temperature, a power in W, the state of the sun - should be simple)
  • documentation on what works and what doesn't, perhaps just as part of the release notes
  • and, perhaps Most Importantly, a logo ;)
@cyclops1982
Copy link
Collaborator

cyclops1982 commented May 17, 2024

  • A simple install guide for Toon would be useful
  • A note on how to contribute
  • That mapping code from dashboard to uicomponents can be improved (and we should)
  • The uicomponent has multiple or no haentities might also be something to fix

@Habbie
Copy link
Member Author

Habbie commented May 17, 2024

  • A simple install guide for Toon would be useful

both /install and /devices cover parts of this, but it can be better, yes.

  • A note on how to contribute

very good idea. I'll make a nice PR adding some semi-simple entity type and use it as an example of how to add widgets, because that's the major non-refactoring work that's next.

  • That mapping code from dashboard to uicomponents can be improved (and we should)
  • The uicomponent has multiple or no haentities might also be something to fix

For both of these I feel expectation management is most important :)

@Habbie
Copy link
Member Author

Habbie commented May 17, 2024

A note on how to contribute

contribute and discuss!

  • things about the code
  • GitHub Discussions
  • IRC

@Habbie
Copy link
Member Author

Habbie commented May 20, 2024

Having now actually tried to use voorkant (main + #89 + #91 + #92) on a Toon1 against my real HA, clearly some more work is needed. Startup takes several minutes at 70%-80% CPU, just to consume all HA state (and debug log extensively about it). Then, with just 8 entities shown, we use 15-30% CPU. Part of that likely is the scrolling of long titles.

So, I think we want:

  • something on the screen way earlier than "we have loaded all HA state"
  • no more scrolling of long titles
  • maybe don't actually get all entities and not subscribe to everything

Also, I'm unsure (because startup took so long) but I think I once got caught trying to do things after the Toon software blanked the screen. Should investigate this and if necessary unblank on startup. (And once we have that, we can do auto-blank and wakeup-on-touch)

@Habbie
Copy link
Member Author

Habbie commented May 20, 2024

the Toon software blanked the screen.

it just happened again while voorkant was running. See also #83

@Habbie Habbie added the v0.1 label May 20, 2024
@cyclops1982
Copy link
Collaborator

The scrolling can be set with labelLongMode. Or at least, that's how it should work :-)

When you say - maybe don't actually get all entities. Do we need some code that gets entities on demand? so while parsing the dashboard we go and get the entities?

@Habbie
Copy link
Member Author

Habbie commented May 20, 2024

Do we need some code that gets entities on demand? so while parsing the dashboard we go and get the entities?

That's the idea, yes. Need to check if the WS API can do it. First I'll see how much faster I can get all of this without making that change.

@Habbie
Copy link
Member Author

Habbie commented May 20, 2024

Startup takes several minutes

it turns out this goes down to 3 seconds if UIDummy doesn't try to log entire state JSONs.

@Habbie Habbie added this to the v0.1 milestone May 20, 2024
@Habbie Habbie removed the v0.1 label May 20, 2024
@cyclops1982
Copy link
Collaborator

cyclops1982 commented May 27, 2024

  • I think I'd like to support a few more plain sensor types (things that just show a temperature, a power in W, the state of the sun - should be simple)

What if we introduce a UISensor that understood a little bit about units and use that instead of UIDummy?

@Habbie
Copy link
Member Author

Habbie commented May 28, 2024

What if we introduce a UISensor that understood a little bit about units and use that instead of UIDummy?

nice one. Just printing the unit from the state might be enough of a start in fact, but UIDummy would have to special case that. UISensor makes sense I think.

@Habbie Habbie mentioned this issue Jun 7, 2024
@Habbie
Copy link
Member Author

Habbie commented Jun 7, 2024

What if we introduce a UISensor that understood a little bit about units and use that instead of UIDummy?

this is #104 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants