Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more constants for layout #86

Open
Habbie opened this issue May 14, 2024 · 1 comment
Open

more constants for layout #86

Habbie opened this issue May 14, 2024 · 1 comment

Comments

@Habbie
Copy link
Member

Habbie commented May 14, 2024

as noted in #68, we could do with a few constants for the sizes of some things. Those constants could then be device-specific, or maybe even calculated at startup (if we define them the right way, no code will care if they're actually constant). While building #68 I kept accidentally creating scrollbars and we can likely do better. Most of the numbers in there are fudged too.

@cyclops1982
Copy link
Collaborator

If we do this, then we need to create like a boxmodel type diagram that indicates which constants are for what. Otherwise this becomes difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants