Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lvgl imageconverter unmodified? #63

Open
Habbie opened this issue Mar 9, 2024 · 1 comment
Open

use lvgl imageconverter unmodified? #63

Habbie opened this issue Mar 9, 2024 · 1 comment
Labels
dev developer things

Comments

@Habbie
Copy link
Member

Habbie commented Mar 9, 2024

The .c files in src/uicomponents/imgs/ are generated with the online converter (see readme in that dir) and then we modify them. I just reduced the level of modification in a commit in #60, but the difference is still big. Part of it is clang-format. It would be nice if we can use the converter without any manual postprocessing (in which case we'd exclude the files from clang-format perhaps)

@Habbie Habbie added the dev developer things label Mar 9, 2024
@Habbie
Copy link
Member Author

Habbie commented Apr 7, 2024

In #73 we found

  • LVGL can load PNGs from disk or a memory buffer fine
  • the built in PNG decoder appears to be slow
  • but there's caching
  • this caching costs RAM
  • the icons as we use them now in imgs/ are fully rendered and cost flash and not RAM

so switching to the decoder fully may not make sense right now, especially if we want to target ESP32 later. However, the possibility to decode at runtime might be great for theming later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer things
Projects
None yet
Development

No branches or pull requests

1 participant