Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/integration: add Spotify integration for fetching cover art #536

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Dec 2, 2024

No description provided.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 76.82119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (a010b9a) to head (aba6dfb).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
nghe-backend/src/integration/spotify.rs 54.83% 11 Missing and 3 partials ⚠️
nghe-backend/src/file/picture/mod.rs 66.66% 0 Missing and 6 partials ⚠️
nghe-backend/src/integration/informant.rs 89.79% 1 Missing and 4 partials ⚠️
nghe-backend/src/config/integration/mod.rs 83.33% 1 Missing and 1 partial ⚠️
nghe-backend/src/lib.rs 0.00% 2 Missing ⚠️
nghe-backend/src/orm/artist_informations.rs 83.33% 0 Missing and 2 partials ⚠️
nghe-backend/src/scan/scanner.rs 50.00% 2 Missing ⚠️
nghe-backend/src/config/mod.rs 0.00% 1 Missing ⚠️
nghe-backend/src/route/scan/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   80.24%   80.10%   -0.15%     
==========================================
  Files         209      215       +6     
  Lines        5401     5568     +167     
  Branches     5401     5568     +167     
==========================================
+ Hits         4334     4460     +126     
- Misses        721      752      +31     
- Partials      346      356      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnghia vnghia merged commit f0608ef into main Dec 2, 2024
13 of 14 checks passed
@vnghia vnghia deleted the artist-image branch December 11, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant