Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve file diff when upgrading package #196

Open
vn971 opened this issue Dec 10, 2022 · 0 comments
Open

Further improve file diff when upgrading package #196

vn971 opened this issue Dec 10, 2022 · 0 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@vn971
Copy link
Owner

vn971 commented Dec 10, 2022

Merge request #192 has introduced a new command to check new files that would be created on filesystem upon package installation. It would, however, be a bit cleaner, if instead of looking at the filesystem, we would look at the contents of the old package and report a pure diff from it. Thus disregarding that the user might have done with their local filesystem.

The feature request is to improve the currently existing command to look at old package contents (can be easily done with a single pacman command) and compare with the new contents we already have in code at that point.

@vn971 vn971 added feature-request New feature or request good first issue Good for newcomers labels Dec 10, 2022
vn971 added a commit that referenced this issue Dec 10, 2022
libalpm allowed dynamically linking to libalpm,
the underlying system library for pacman.
This allowed interfacing with the pacman internal database
at potentially much higher speed.

However, this also causes `rua` to break if libalpm's ABI changes.
The simpler alternative of just querying `pacman` and asking
the required data seems to work quite well over the last 1-2 years.

This commit removes support for the old approach and leaves
just 1 alternative for simplicity and stability.
This also allows adding new features faster,
see e.g. #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant