-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonobuoy wait
requires --wait
flag to be functional
#1954
Comments
embik
changed the title
Behaviour of
Dec 21, 2023
sonobuoy wait
changed from v0.56.16 to v0.56.17, requires --wait
flag nowsonobuoy wait
requires --wait
flag to be functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps did you take and what happened:
We noticed that starting from v0.56.17 / v0.57.x, the behaviour of
sonobuoy wait
changed - In the "before" version, it will wait (as expected) until tests have finished or a certain timeout has been reached:In the "after" version,
sonobuoy wait
immediately returns with the following error:The command only works if you pass the
--wait
flag, which seems like an odd "default usage".This can be reproduced by switching between the
v0.56.16
and thev0.56.17
git tag, building the binary and comparing behaviour of the command.What did you expect to happen:
sonobuoy wait
continues to exhibit consistent behaviour between patch releases.Anything else you would like to add:
I was wondering if f5aa6ba was the culprit of this, but there isn't anything obvious in this commit that would cause this.
Environment:
kubectl version
):v1.27.6
/etc/os-release
): n/aThe text was updated successfully, but these errors were encountered: